Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Debugbar request microtime #5958

Merged
merged 4 commits into from
May 5, 2022
Merged

feat: Debugbar request microtime #5958

merged 4 commits into from
May 5, 2022

Conversation

kenjis
Copy link
Member

@kenjis kenjis commented May 4, 2022 •
edited
Loading

Description
Supersedes #5643
I was not able to rebase #5643 because of too many conflicts.

Screenshot 2022-05-04 17 59 42

Checklist:

  • Securely signed commits
  • Component(s) with PHPDoc blocks, only if necessary or adds value
  • Unit testing, with >80% coverage
  • User guide updated
  • Conforms to style guide

@kenjis kenjis added breaking change Pull requests that may break existing functionalities enhancement PRs that improve existing functionalities labels May 4, 2022
@kenjis kenjis force-pushed the debugbar-request-microtime branch from 6ed9463 to b8395b7 Compare May 4, 2022 09:01
@kenjis kenjis force-pushed the debugbar-request-microtime branch from 5a19fa8 to 02b120a Compare May 4, 2022 09:09
@kenjis kenjis requested a review from paulbalandan May 5, 2022 00:29
paulbalandan
paulbalandan reviewed May 5, 2022
View reviewed changes
Copy link
Member

@paulbalandan paulbalandan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor comment

system/Debug/Toolbar.php Outdated Show resolved Hide resolved
@kenjis @paulbalandan
fix: typo in log message
e04901a 
Co-authored-by: John Paul E. Balandan, CPA <51850998+paulbalandan@users.noreply.github.com>
@kenjis kenjis merged commit 95437a4 into codeigniter4:develop May 5, 2022
@kenjis kenjis deleted the debugbar-request-microtime branch May 5, 2022 05:27
@kenjis kenjis mentioned this pull request May 5, 2022
Closed
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@paulbalandan paulbalandan paulbalandan approved these changes

Assignees
No one assigned
Labels
breaking change Pull requests that may break existing functionalities enhancement PRs that improve existing functionalities
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kenjis @paulbalandan