-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: system/bootstrap.php
only loads files and registers autoloader
#5972
Conversation
system/bootstrap.php
does only load files and autoloader registeration
system/bootstrap.php
does only load files and autoloader registerationsystem/bootstrap.php
only loads files and registers autoloader
46e4f8f
to
5cba764
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I will have to look at this o desktop, it's a little hard on mobile to tell what moved where.
I'm not sure the answer to this but... is changing the return of a file (bootstrap.php) considered a breaking change?
Yes. I added the changelog and upgrade guide. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I understand all the moves now. I don't think the bootstrap.php return is an issue - I'm actually glad we won't be relying on that anymore.
One phrasing suggestion, and let's make sure @lonnieezell has seen this one.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since it already had a couple of other approvals I didn't scan every line. I have no problems with the changes, but I do think we should let people know why the changes are happening. My first thought on reading the title of the issue was, "Why are we changing? Is there any benefit to possibly breaking people's apps for this or is it just to be "proper"?" Turns out there is a very good reason, but let's help people get to that conclusion before they get upset lol.
No need to use it.
Co-authored-by: MGatner <mgatner@icloud.com>
ec95551
to
d3baa55
Compare
Description
When we want to use Preloading, we need CI4 Autoloader.
But it is not easy to make the Autoloader work fine.
If you use this
system/bootstrap.php
, you can make it a bit easily.CodeIgniter
instantiation andDotEnv
loading fromsystem/bootstrap.php
index.php
andspark.php
Checklist: