Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: deprecate const EVENT_PRIORITY_* #6000

Merged
merged 2 commits into from
May 18, 2022
Merged

refactor: deprecate const EVENT_PRIORITY_* #6000

merged 2 commits into from
May 18, 2022

Conversation

kenjis
Copy link
Member

@kenjis kenjis commented May 17, 2022

Description
Fixes #5977

  • deprecated EVENT_PRIORITY_*
  • add Events::PRIORITY_*

Checklist:

  • Securely signed commits
  • [] Component(s) with PHPDoc blocks, only if necessary or adds value
  • [] Unit testing, with >80% coverage
  • User guide updated
  • Conforms to style guide

@kenjis kenjis mentioned this pull request May 17, 2022
Closed
@kenjis kenjis added the refactor Pull requests that refactor code label May 17, 2022
@kenjis kenjis mentioned this pull request May 17, 2022
Merged
4 tasks
MGatner
MGatner approved these changes May 17, 2022
View reviewed changes
Copy link
Member

@MGatner MGatner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

@kenjis kenjis merged commit 0153f4f into codeigniter4:develop May 18, 2022
@kenjis kenjis deleted the deprecate-const-EVENT_PRIORITY branch May 18, 2022 03:12
@kenjis kenjis mentioned this pull request May 18, 2022
Merged
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@paulbalandan paulbalandan paulbalandan approved these changes

@MGatner MGatner MGatner approved these changes

Assignees
No one assigned
Labels
refactor Pull requests that refactor code
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

define() in Events
3 participants
@kenjis @MGatner @paulbalandan