Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Router class optimization. #6004

Merged
merged 3 commits into from
May 19, 2022
Merged

Router class optimization. #6004

merged 3 commits into from
May 19, 2022

Conversation

iRedds
Copy link
Collaborator

@iRedds iRedds commented May 18, 2022

Description
Duplicate code moved to a separate method.
Removed code that had no effect on the work.
Optimization.

Checklist:

  • Securely signed commits
  • Unit testing, with >80% coverage
  • Conforms to style guide

Signed-off-by: Andrey Pyzhikov <5071@mail.ru>
@kenjis kenjis added the refactor Pull requests that refactor code label May 18, 2022
Signed-off-by: Andrey Pyzhikov <5071@mail.ru>
Signed-off-by: Andrey Pyzhikov <5071@mail.ru>
@samsonasik samsonasik merged commit 9b474c7 into codeigniter4:develop May 19, 2022
@samsonasik
Copy link
Member

Thank you @iRedds

@iRedds iRedds deleted the router branch May 19, 2022 17:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
refactor Pull requests that refactor code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants