Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: use get_filenames() 4th param #6031

Merged
merged 1 commit into from
May 26, 2022
Merged

refactor: use get_filenames() 4th param #6031

merged 1 commit into from
May 26, 2022

Conversation

kenjis
Copy link
Member

@kenjis kenjis commented May 26, 2022

Description

  • No need to return directories

Ref #6026

Checklist:

  • Securely signed commits
  • [] Component(s) with PHPDoc blocks, only if necessary or adds value
  • [] Unit testing, with >80% coverage
  • [] User guide updated
  • Conforms to style guide

@kenjis
refactor: use get_filenames() 4th param
c65a26d 
No need to return directories.
@kenjis kenjis added the refactor Pull requests that refactor code label May 26, 2022
@kenjis kenjis merged commit f63e6e5 into codeigniter4:develop May 26, 2022
@kenjis kenjis deleted the refactor-get_filenames-4th-param branch May 26, 2022 08:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@paulbalandan paulbalandan paulbalandan approved these changes

Assignees
No one assigned
Labels
refactor Pull requests that refactor code
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kenjis @paulbalandan