chore(deps-dev): update rector/rector requirement from 0.13.0 to 0.13.2 #6052
Conversation
![dependabot[bot]](https://avatars.githubusercontent.com/in/29110?s=60&v=4){kind=small}
Updates the requirements on [rector/rector](https://github.com/rectorphp/rector) to permit the latest version. - [Release notes](https://github.com/rectorphp/rector/releases) - [Commits](rectorphp/rector@0.13.0...0.13.2) --- updated-dependencies: - dependency-name: rector/rector dependency-type: direct:development ... Signed-off-by: dependabot[bot] <support@github.com>
dependabot
bot
added
dependencies
…n lastname is exists in use statements
|
I cleaned up config, re-run rector, and set alias to Config\ClassName when lastname is exists in use statements |
|
test error on Oracle test seems unrelated: |
|
PHPStan internal error seems unrelated: Error: Internal error: Internal error: Undefined constant "CodeIgniter\Database\OCI8\OCI_COMMIT_ON_SUCCESS" in file /home/runner/work/CodeIgniter4/CodeIgniter4/system/Database/OCI8/Builder.php
Run PHPStan with -v option and post the stack trace to:
https://github.com/phpstan/phpstan/issues/new?template=Bug_report.md
Error: Child process error (exit code 1):
-- ---------------------------------------------------------------------------
Error
-- ---------------------------------------------------------------------------
Internal error: Internal error: Undefined constant
"CodeIgniter\Database\OCI8\OCI_COMMIT_ON_SUCCESS" in file
/home/runner/work/CodeIgniter4/CodeIgniter4/system/Database/OCI8/Builder. It seems we need to create a fallback check on when |
…SS constant when not defined
|
@samsonasik Sorry, https://github.com/codeigniter4/CodeIgniter4/blob/develop/tests/_support/Services.php |
|
@kenjis ok, just let me know if I need to update it. |
|
Probably |
|
Ok, I set |
|
Why |
|
It got warning in my local, while working on CI, ok, I set back to true |
Co-authored-by: kenjis <kenji.uui@gmail.com>
|
All green 🎉 , let's merge it, thank you @kenjis @paulbalandan for the review. |
Updates the requirements on rector/rector to permit the latest version.
Release notes
Sourced from rector/rector's releases.
Commits
5c55299Rector 0.13.264b3510Updated Rector to commit 31e60de5c9fc7ce2f71c6af2c9a22b634b77809f15bac77Updated Rector to commit e89590f92503dc848855035f76da5aa607370fe485ff702Updated Rector to commit 38cb4c9684920ceeb121ced398fd7e3c70f6435eefe571aRector 0.13.1ed2a4f1Updated Rector to commit 429e5746ea00b435d7a785c7716600e556b4d3d25ac1afdUpdated Rector to commit 7f40d20ff75b7a712815862110c66c445e1fb8c5b748edbUpdated Rector to commit 37df55a2fd1a2d6baceb128d8d25cabb19bea83372da510Updated Rector to commit 30b5b53c0ed3031b75341efe02a53d8367861dd44838a73Updated Rector to commit 38ed8d2f6d765cc8ca7bfa9d2c3105d05f9109ffDependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebasewill rebase this PR@dependabot recreatewill recreate this PR, overwriting any edits that have been made to it@dependabot mergewill merge this PR after your CI passes on it@dependabot squash and mergewill squash and merge this PR after your CI passes on it@dependabot cancel mergewill cancel a previously requested merge and block automerging@dependabot reopenwill reopen this PR if it is closed@dependabot closewill close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually@dependabot ignore this major versionwill close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor versionwill close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependencywill close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)