Fix slash_item() erroring when property fetched does not exist on Config\App
#6058
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
paulbalandan
added
the
bug
kenjis
reviewed
Jun 1, 2022
kenjis
reviewed
Jun 2, 2022
Comment on lines
+397
to
+399
| $this->assertSame('7200/', slash_item('sessionExpiration')); // int 7200 | ||
| $this->assertSame('', slash_item('negotiateLocale')); // false | ||
| $this->assertSame('1/', slash_item('cookieHTTPOnly')); // true |
There was a problem hiding this comment.
I can't think use cases like these, but this behavior is not changed.
There was a problem hiding this comment.
Yeah. Just to show these cases are covered by tests.
samsonasik
approved these changes
Jun 2, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Supersedes and closes #5973
Fixes #5967
Checklist: