fix: get_cookie() may not use the cookie prefix #6082
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Needs to rebase after merging #6080Description
Fixes #6009
Supersede #6024
The current
get_cookie()
behavior is strange. See Behavior Changes below.This PR changes it the following:
get_cookie($index)
always use the cookie prefix in Config fileget_cookie($index, $xssClean, null)
never uses the cookie prefixBehavior Changes
When the cookie prefix is
prefix_
andBefore:
After:
Checklist: