Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Session cookies are sent twice with Ajax #6167

Merged
merged 1 commit into from
Jun 21, 2022
Merged

fix: Session cookies are sent twice with Ajax #6167

merged 1 commit into from
Jun 21, 2022

Conversation

kenjis
Copy link
Member

@kenjis kenjis commented Jun 21, 2022 •
edited
Loading

Description
Fixes #6166
Follow-up #5656

How to Test
See #6166 (comment)

Checklist:

  • Securely signed commits
  • Component(s) with PHPDoc blocks, only if necessary or adds value
  • Unit testing, with >80% coverage
  • User guide updated
  • Conforms to style guide

@kenjis kenjis added the bug Verified issues on the current code behavior or pull requests that will fix them label Jun 21, 2022
@kenjis kenjis mentioned this pull request Jun 21, 2022
Closed
MGatner
MGatner approved these changes Jun 21, 2022
View reviewed changes
Copy link
Member

@MGatner MGatner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very odd that we have a mix of mutability and immutability within the same class. This fix looks good though!

@MGatner
Copy link
Member

MGatner commented Jun 21, 2022

Special thanks also to @skuadron45 for the extensive testing and reporting!

@skuadron45
Copy link

i already tested this PR, see comment at #6166

@skuadron45
Copy link

Special thanks also to @skuadron45 for the extensive testing and reporting!

your welcome @MGatner

@kenjis
Copy link
Member Author

kenjis commented Jun 21, 2022

Very odd that we have a mix of mutability and immutability within the same class.

Yes, and it is difficult to remove a cookie in Response.

@kenjis kenjis merged commit 91909c4 into codeigniter4:develop Jun 21, 2022
@kenjis kenjis deleted the fix-session-cookie-twice-ajax branch June 21, 2022 21:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@samsonasik samsonasik samsonasik approved these changes

@MGatner MGatner MGatner approved these changes

Assignees
No one assigned
Labels
bug Verified issues on the current code behavior or pull requests that will fix them
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Bug: Session cookies are sent twice with Ajax
4 participants
@kenjis @MGatner @skuadron45 @samsonasik