-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: $routes->group('/', ...)
creates the route foo///bar
#6186
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you add tests for the following please?
- Group '/', subgroup ''
- Group '', subgroup ''
- Group '', subgroup '/'
Added tests. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you. Looks good pending test results.
system/Router/RouteCollection.php
Outdated
@@ -625,7 +625,7 @@ public function group(string $name, ...$params) | |||
// To register a route, we'll set a flag so that our router | |||
// so it will see the group name. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think the "so it" can be removed the way the previous line is phrased.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@sfadschm Oh, thanks! I didn't understand the sentence.
Description
creates
This PR fixes the route:
Checklist: