Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: $routes->group('/', ...) creates the route foo///bar #6186

Merged
merged 3 commits into from
Jun 26, 2022

Conversation

kenjis
Copy link
Member

@kenjis kenjis commented Jun 26, 2022

Description

$routes->group('admin', static function ($routes) {
    $routes->group('/', static function ($routes) {
        $routes->get('list', 'Admin\Users::list');
    });
});

creates

+--------+--------------+------------------------------------------+----------------+---------------+
| Method | Route        | Handler                                  | Before Filters | After Filters |
+--------+--------------+------------------------------------------+----------------+---------------+
| GET    | admin///list | \App\Controllers\Admin\Users::list       |                | toolbar       |
+--------+--------------+------------------------------------------+----------------+---------------+

This PR fixes the route:

+--------+------------+------------------------------------------+----------------+---------------+
| Method | Route      | Handler                                  | Before Filters | After Filters |
+--------+------------+------------------------------------------+----------------+---------------+
| GET    | admin/list | \App\Controllers\Admin\Users::list       |                | toolbar       |
+--------+------------+------------------------------------------+----------------+---------------+

Checklist:

  • Securely signed commits
  • Component(s) with PHPDoc blocks, only if necessary or adds value
  • Unit testing, with >80% coverage
  • User guide updated
  • Conforms to style guide

@kenjis kenjis added the bug Verified issues on the current code behavior or pull requests that will fix them label Jun 26, 2022
Copy link
Member

@MGatner MGatner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add tests for the following please?

  1. Group '/', subgroup ''
  2. Group '', subgroup ''
  3. Group '', subgroup '/'

@kenjis
Copy link
Member Author

kenjis commented Jun 26, 2022

Added tests.

Copy link
Member

@MGatner MGatner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you. Looks good pending test results.

@@ -625,7 +625,7 @@ public function group(string $name, ...$params)
// To register a route, we'll set a flag so that our router
// so it will see the group name.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the "so it" can be removed the way the previous line is phrased.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sfadschm Oh, thanks! I didn't understand the sentence.

@kenjis kenjis merged commit 053d669 into codeigniter4:develop Jun 26, 2022
@kenjis kenjis deleted the fix-routes-group-slash branch June 26, 2022 23:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Verified issues on the current code behavior or pull requests that will fix them
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants