Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: custom validation error is cleared when calling setRule() twice #6241

Merged
merged 2 commits into from
Jul 8, 2022
Merged

fix: custom validation error is cleared when calling setRule() twice #6241

merged 2 commits into from
Jul 8, 2022

Conversation

kenjis
Copy link
Member

@kenjis kenjis commented Jul 8, 2022 •
edited
Loading

Description
Fixes #6239

Checklist:

  • Securely signed commits
  • [] Component(s) with PHPDoc blocks, only if necessary or adds value
  • Unit testing, with >80% coverage
  • [] User guide updated
  • Conforms to style guide

@kenjis kenjis added the bug Verified issues on the current code behavior or pull requests that will fix them label Jul 8, 2022
@kenjis kenjis mentioned this pull request Jul 8, 2022
Closed
MGatner
MGatner approved these changes Jul 8, 2022
View reviewed changes
Copy link
Member

@MGatner MGatner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice test cases.

@kenjis kenjis merged commit ba7d36c into codeigniter4:develop Jul 8, 2022
@kenjis kenjis deleted the fix-validation-setRule-errors branch July 8, 2022 22:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@paulbalandan paulbalandan paulbalandan approved these changes

@MGatner MGatner MGatner approved these changes

Assignees
No one assigned
Labels
bug Verified issues on the current code behavior or pull requests that will fix them
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Bug: Custom validation error is cleared when setting rule twice
3 participants
@kenjis @MGatner @paulbalandan