Fix: Validation of fields with a leading asterisk. #6243
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ddevsr
approved these changes
Jul 8, 2022
MGatner
approved these changes
Jul 8, 2022
|
Original reporter verifies this works 💪 |
kenjis
reviewed
Jul 9, 2022
| ['foo' => null], | ||
| ]; | ||
|
|
||
| $this->validation->setRules(['*.foo' => 'required'], ['1.foo' => ['required' => 'Required {field}']]); |
There was a problem hiding this comment.
This is not related with this bug, but ['1.foo' => ['required' => 'Required {field}']] seems tricky .
I would like to write ['*.foo' => ['required' => 'Required {field}']].
There was a problem hiding this comment.
You know, it turned out that the option you suggested does not work. The default error text is returned.
There was a problem hiding this comment.
The error text will be defined for the *.foo field, and the 1.foo field is passed.
kenjis
approved these changes
Jul 9, 2022
|
Thank you! @iRedds |
kenjis
added
the
bug
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
https://forum.codeigniter.com/showthread.php?tid=82391&pid=398147#pid398147
Fixed: Validation of fields with a leading asterisk (wildcard).
Also fixed getting an error by field name with a leading asterisk.
Checklist: