Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: exceptionHandler may cause HTTPException: Unknown HTTP status code #6254

Merged
merged 3 commits into from
Jul 13, 2022
Merged

fix: exceptionHandler may cause HTTPException: Unknown HTTP status code #6254

merged 3 commits into from
Jul 13, 2022

Conversation

kenjis
Copy link
Member

@kenjis kenjis commented Jul 12, 2022 •
edited
Loading

Description
Fixes #6227

Checklist:

  • Securely signed commits
  • [] Component(s) with PHPDoc blocks, only if necessary or adds value
  • Unit testing, with >80% coverage
  • User guide updated
  • Conforms to style guide

@kenjis kenjis added the bug Verified issues on the current code behavior or pull requests that will fix them label Jul 12, 2022
@kenjis kenjis mentioned this pull request Jul 12, 2022
Merged
5 tasks
MGatner
MGatner approved these changes Jul 12, 2022
View reviewed changes
Copy link
Member

@MGatner MGatner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Definitely much narrower scope but it gets the job done.

@kenjis kenjis requested a review from paulbalandan July 12, 2022 22:08
@kenjis kenjis merged commit 8725d38 into codeigniter4:develop Jul 13, 2022
@kenjis kenjis deleted the fix-exceptionHandler-statusCode-min branch July 13, 2022 02:14
@kenjis
Copy link
Member Author

kenjis commented Jul 13, 2022

Thank you, guys!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@paulbalandan paulbalandan paulbalandan approved these changes

@MGatner MGatner MGatner approved these changes

Assignees
No one assigned
Labels
bug Verified issues on the current code behavior or pull requests that will fix them
Projects
None yet
Milestone
No milestone
3 participants
@kenjis @MGatner @paulbalandan