fix: format_number() can't be used on CLI #6263
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We are using Locale::getDefault().
kenjis
added
the
bug
MGatner
approved these changes
Jul 13, 2022
Comment on lines
-193
to
+194
| locale_set_default($this->config->defaultLocale ?? 'en'); | ||
| Locale::setDefault($this->config->defaultLocale ?? 'en'); |
There was a problem hiding this comment.
I'm curious why you changed this. Isn't they the same?
There was a problem hiding this comment.
Now we are using Locale::getDefault() and I searched Locale::setDefault() but not found.
Using locale_set_default() and Locale::getDefault() is not consistent.
Co-authored-by: MGatner <mgatner@icloud.com>
samsonasik
approved these changes
Jul 14, 2022
|
Thank you @kenjis |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
format_number()depends onIncommingRequest::getLocale(), and causes ErrorCall to undefined method CodeIgniter\HTTP\CLIRequest::getLocale().Checklist: