Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: route name is not displayed in Exception message #6269

Merged
merged 1 commit into from
Jul 20, 2022
Merged

fix: route name is not displayed in Exception message #6269

merged 1 commit into from
Jul 20, 2022

Conversation

kenjis
Copy link
Member

@kenjis kenjis commented Jul 16, 2022 •
edited
Loading

Description

  • fix exception message

This PR changes the lang file:

-    'invalidRoute' => '{0} route cannot be found while reverse-routing.',
+    'invalidRoute' => 'The route for "{0}" cannot be found.',

Checklist:

  • Securely signed commits
  • Component(s) with PHPDoc blocks, only if necessary or adds value
  • Unit testing, with >80% coverage
  • User guide updated
  • Conforms to style guide

@kenjis kenjis added the bug Verified issues on the current code behavior or pull requests that will fix them label Jul 16, 2022
@samsonasik samsonasik merged commit fe45d33 into codeigniter4:develop Jul 20, 2022
@samsonasik
Copy link
Member

Thank you @kenjis

@kenjis kenjis deleted the fix-forInvalidRedirectRoute-message branch July 20, 2022 21:42
@kenjis kenjis mentioned this pull request Jul 20, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@samsonasik samsonasik samsonasik approved these changes

Assignees
No one assigned
Labels
bug Verified issues on the current code behavior or pull requests that will fix them
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kenjis @samsonasik