Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: Exception exit code #6286

Merged
merged 5 commits into from
Jul 24, 2022
Merged

refactor: Exception exit code #6286

merged 5 commits into from
Jul 24, 2022

Conversation

kenjis
Copy link
Member

@kenjis kenjis commented Jul 22, 2022 •
edited
Loading

Description

  • replace magic numbers with constants
  • add test cases

Checklist:

  • Securely signed commits
  • [] Component(s) with PHPDoc blocks, only if necessary or adds value
  • [] Unit testing, with >80% coverage
  • [] User guide updated
  • Conforms to style guide

@kenjis kenjis added the refactor Pull requests that refactor code label Jul 22, 2022
@kenjis kenjis mentioned this pull request Jul 22, 2022
Merged
5 tasks
MGatner
MGatner approved these changes Jul 23, 2022
View reviewed changes
Copy link
Member

@MGatner MGatner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like part of the problem is that the old CastException was a CriticalError while the new one is a FrameworkException. Not sure how that slipped by but it makes extending the old one a problem - unless we want to revert that change and have it be an error again.

@kenjis kenjis merged commit 0b49de3 into codeigniter4:develop Jul 24, 2022
@kenjis kenjis deleted the refactor-exception-exit-code branch July 24, 2022 00:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MGatner MGatner MGatner approved these changes

Assignees
No one assigned
Labels
refactor Pull requests that refactor code
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kenjis @MGatner