Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Security::derandomize() may cause hex2bin() error #6292

Merged
merged 1 commit into from
Jul 25, 2022
Merged

fix: Security::derandomize() may cause hex2bin() error #6292

merged 1 commit into from
Jul 25, 2022

Conversation

kenjis
Copy link
Member

@kenjis kenjis commented Jul 23, 2022 •
edited
Loading

Description
From https://forum.codeigniter.com/showthread.php?tid=82544

Security::derandomize() may throw ErrorException "hex2bin(): Hexadecimal input string must have an even length".

Checklist:

  • Securely signed commits
  • Component(s) with PHPDoc blocks, only if necessary or adds value
  • Unit testing, with >80% coverage
  • [] User guide updated
  • Conforms to style guide

@kenjis kenjis added the bug Verified issues on the current code behavior or pull requests that will fix them label Jul 23, 2022
MGatner
MGatner approved these changes Jul 24, 2022
View reviewed changes
Copy link
Member

@MGatner MGatner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Thanks for the quick fix @kenjis

@kenjis kenjis merged commit cee5528 into codeigniter4:develop Jul 25, 2022
@kenjis kenjis deleted the fix-Security-derandomize branch July 25, 2022 01:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MGatner MGatner MGatner approved these changes

Assignees
No one assigned
Labels
bug Verified issues on the current code behavior or pull requests that will fix them
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kenjis @MGatner