-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add $cached param to BaseConnection::tableExists() #6364
Conversation
Any idea what is wrong with Mock?
public function query(string $sql, $binds = null, bool $setEscapeFlags = true, string $queryClass = '')
{
$queryClass = str_replace('Connection', 'Query', static::class);
$query = new $queryClass($this); |
Because it uses PHPUnit mock. Don't worry. The test is no longer of much use. |
I'll remove it and create a live test |
No, you can't. The part
Yes, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is good work! Please address the comments.
d16bddc
to
44d02a8
Compare
I added code that detects when cache is out of sync. If out of sync then we call However only if |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me! Thanks for the null changes. @kenjis anything else from you?
50dbb61
to
8077f2f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you.
Follow-up #6249
This PR fixes #6351
In
Forge::createTable()
This PR forces to check if table exists rather than relying on cache.
We add $tableName param to
Connection::_listTables()
. This allows us to lookup only one table rather than return a full list of tables.Checklist: