Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: ValidationTest #6382

Merged
merged 1 commit into from
Aug 16, 2022
Merged

refactor: ValidationTest #6382

merged 1 commit into from
Aug 16, 2022

Conversation

kenjis
Copy link
Member

@kenjis kenjis commented Aug 16, 2022

Description

  • use inheritance

Checklist:

  • Securely signed commits
  • [] Component(s) with PHPDoc blocks, only if necessary or adds value
  • [] Unit testing, with >80% coverage
  • [] User guide updated
  • Conforms to style guide

@kenjis kenjis added testing Pull requests that changes tests only refactor Pull requests that refactor code labels Aug 16, 2022
MGatner
MGatner approved these changes Aug 16, 2022
View reviewed changes
Copy link
Member

@MGatner MGatner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm surprised PHPCPD didn't catch us on that.

@kenjis kenjis merged commit e34c5e3 into codeigniter4:develop Aug 16, 2022
@kenjis kenjis deleted the refactor-ValidationTests branch August 16, 2022 22:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MGatner MGatner MGatner approved these changes

Assignees
No one assigned
Labels
refactor Pull requests that refactor code testing Pull requests that changes tests only
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kenjis @MGatner