Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: fix $pathsConfig line number #6386

Merged
merged 3 commits into from
Aug 18, 2022
Merged

Conversation

totoprayogo1916
Copy link
Contributor

$pathsConfig line number changed after #6327

Checklist:

  • Securely signed commits
  • User guide updated

@paulbalandan
Copy link
Member

Just wondering if we really need to specify in the docs the actual line numbers? IMO this is unnecessary maintenance of tracking the line numbers every time the code there changes.

@totoprayogo1916
Copy link
Contributor Author

Maybe it's better to just remove the line number.

@kenjis kenjis added the documentation Pull requests for documentation only label Aug 17, 2022
@kenjis kenjis changed the title docs:fix $systemDirectory and $pathsConfig line number docs: fix $systemDirectory and $pathsConfig line number Aug 17, 2022
@kenjis
Copy link
Member

kenjis commented Aug 17, 2022

This work is ridiculous. It is better to remove the line numbers.

And now the code is like this:

// Load our paths config file
// This is the line that might need to be changed, depending on your folder structure.
require FCPATH . '../app/Config/Paths.php';
// ^^^ Change this line if you move your application folder
// Load our paths config file
// This is the line that might need to be changed, depending on your folder structure.
require FCPATH . '../app/Config/Paths.php';
// ^^^ Change this line if you move your application folder

Copy link
Member

@kenjis kenjis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@totoprayogo1916 totoprayogo1916 changed the title docs: fix $systemDirectory and $pathsConfig line number docs: fix $pathsConfig line number Aug 17, 2022
@totoprayogo1916
Copy link
Contributor Author

changes, for $systemDirectory I aborted because it's related to multiple apps

@kenjis kenjis merged commit 0f16cae into codeigniter4:develop Aug 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Pull requests for documentation only
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants