Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: CLIRequest Erros in CLI #6421

Merged
merged 6 commits into from
Aug 27, 2022
Merged

fix: CLIRequest Erros in CLI #6421

merged 6 commits into from
Aug 27, 2022

Conversation

kenjis
Copy link
Member

@kenjis kenjis commented Aug 24, 2022 •
edited
Loading

Description

Ref #6089

Checklist:

  • Securely signed commits
  • Component(s) with PHPDoc blocks, only if necessary or adds value
  • Unit testing, with >80% coverage
  • User guide updated
  • Conforms to style guide

@kenjis kenjis added the bug Verified issues on the current code behavior or pull requests that will fix them label Aug 24, 2022
@kenjis kenjis marked this pull request as draft August 24, 2022 23:59
@kenjis kenjis marked this pull request as ready for review August 25, 2022 00:16
@kenjis kenjis mentioned this pull request Aug 25, 2022
Closed
MGatner
MGatner reviewed Aug 25, 2022
View reviewed changes
Copy link
Member

@MGatner MGatner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This might need to be split up. Let's get at least one more review in here first.

I think this is a good change, follow up to the Services::createRequest() work.

system/HTTP/CLIRequest.php Outdated Show resolved Hide resolved
@kenjis
fix: remove harmful @mixin in RequestInterface
b53d482 
In a class that implements RequestInterface, a method that does not actually exist was displayed
in the IDE as if it existed.
@kenjis
fix: add missing get*() methods in CLIRequest
dff94db
@kenjis
fix: Honeypot filter causes error
873f616 
Call to undefined method CodeIgniter\HTTP\CLIRequest::getPost()
@kenjis
test: update NegotiateTest
8c37dd1
@kenjis
test: remove unneeded tearDown()
42ac32d
@kenjis kenjis changed the title fix: Honeypot filter causes Error in CLI fix: CLIRequest Erros in CLI Aug 27, 2022
@MGatner
Copy link
Member

MGatner commented Aug 27, 2022

Looks good!

@kenjis kenjis merged commit e686a14 into codeigniter4:develop Aug 27, 2022
@kenjis kenjis deleted the fix-RequestInterface-mixin branch August 27, 2022 12:19
This was referenced Aug 27, 2022
Closed
Merged
@kenjis kenjis mentioned this pull request Oct 9, 2022
Merged
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MGatner MGatner MGatner approved these changes

Assignees
No one assigned
Labels
bug Verified issues on the current code behavior or pull requests that will fix them
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Bug: Call to undefined method CodeIgniter\HTTP\CLIRequest::getPost() while running the CLI routes
2 participants
@kenjis @MGatner