Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump friendsofphp/php-cs-fixer to ~3.11.0 #6471

Merged
merged 5 commits into from
Sep 3, 2022

Conversation

paulbalandan
Copy link
Member

Description
Supersedes and closes #6252

New rules since v3.6 will be added incrementally in succeeding PRs. This PR just adjusts the formatting based on existing rules in our ruleset.

Checklist:

  • Securely signed commits
  • Component(s) with PHPDoc blocks, only if necessary or adds value
  • Unit testing, with >80% coverage
  • User guide updated
  • Conforms to style guide

Copy link
Member

@kenjis kenjis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link
Member

@MGatner MGatner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good by me! Though eventually the docblock grouping should make it into our Coding Standard and be removed from $overrides.

@paulbalandan paulbalandan merged commit 7b2ad9c into codeigniter4:develop Sep 3, 2022
@paulbalandan paulbalandan deleted the cs-fixer branch September 3, 2022 14:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants