Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: fix inappropriate sample code in Response #6526

Merged
merged 1 commit into from
Sep 11, 2022
Merged

docs: fix inappropriate sample code in Response #6526

merged 1 commit into from
Sep 11, 2022

Conversation

kenjis
Copy link
Member

@kenjis kenjis commented Sep 10, 2022 •
edited
Loading

Description
There are no microseconds in the Last-Modified header:
https://developer.mozilla.org/en-US/docs/Web/HTTP/Headers/Last-Modified

See #6480 (comment)

Checklist:

  • Securely signed commits
  • [] Component(s) with PHPDoc blocks, only if necessary or adds value
  • [] Unit testing, with >80% coverage
  • User guide updated
  • Conforms to style guide

@kenjis kenjis added the documentation Pull requests for documentation only label Sep 10, 2022
@kenjis kenjis mentioned this pull request Sep 10, 2022
Merged
5 tasks
@kenjis kenjis merged commit af25fe2 into codeigniter4:develop Sep 11, 2022
@kenjis kenjis deleted the fix-docs-Response-setLastModified branch September 11, 2022 23:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@paulbalandan paulbalandan paulbalandan approved these changes

@MGatner MGatner MGatner approved these changes

Assignees
No one assigned
Labels
documentation Pull requests for documentation only
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kenjis @MGatner @paulbalandan