Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update coding-standards version #6537

Merged
merged 3 commits into from
Sep 27, 2022

Conversation

paulbalandan
Copy link
Member

@paulbalandan paulbalandan commented Sep 13, 2022

  • "codeigniter/coding-standard": "^1.5"
  • "nexusphp/cs-config": "^3.6",

Checklist:

  • Securely signed commits
  • Component(s) with PHPDoc blocks, only if necessary or adds value
  • Unit testing, with >80% coverage
  • User guide updated
  • Conforms to style guide

@kenjis
Copy link
Member

kenjis commented Sep 14, 2022

It seems better to change the sample code.

    1) CodeIgniter4/user_guide_src/source/outgoing/response/018.php (date_time_create_from_format_call)
      ---------- begin diff ----------
--- /home/runner/work/CodeIgniter4/CodeIgniter4/user_guide_src/source/outgoing/response/018.php
+++ /home/runner/work/CodeIgniter4/CodeIgniter4/user_guide_src/source/outgoing/response/018.php
@@ -1,4 +1,4 @@
 <?php
 
-$date = DateTime::createFromFormat('j-M-Y', '15-Feb-2016');
+$date = DateTime::createFromFormat('!j-M-Y', '15-Feb-2016');
 $response->setDate($date);

      ----------- end diff -----------

@MGatner
Copy link
Member

MGatner commented Sep 15, 2022

Yes I am in favor of updating the examples so they always match our coding standard; that was the primary reason behind splitting them out.

I wish there were a way to exempt 'U' from the ! rule; I think it is better to have it than dropping the rule, but it is a logical redundancy.

@MGatner
Copy link
Member

MGatner commented Sep 15, 2022

@paulbalandan Could you make the parallel changes over at codeigniter4/devkit as well please?

@paulbalandan
Copy link
Member Author

@paulbalandan Could you make the parallel changes over at codeigniter4/devkit as well please?

Done. codeigniter4/devkit#47

@kenjis kenjis mentioned this pull request Sep 26, 2022
5 tasks
@kenjis kenjis merged commit 8a93b65 into codeigniter4:develop Sep 27, 2022
@kenjis kenjis added the enhancement PRs that improve existing functionalities label Sep 27, 2022
@paulbalandan paulbalandan deleted the coding-standards branch September 27, 2022 23:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement PRs that improve existing functionalities
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants