-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update coding-standards version #6537
Conversation
It seems better to change the sample code. 1) CodeIgniter4/user_guide_src/source/outgoing/response/018.php (date_time_create_from_format_call)
---------- begin diff ----------
--- /home/runner/work/CodeIgniter4/CodeIgniter4/user_guide_src/source/outgoing/response/018.php
+++ /home/runner/work/CodeIgniter4/CodeIgniter4/user_guide_src/source/outgoing/response/018.php
@@ -1,4 +1,4 @@
<?php
-$date = DateTime::createFromFormat('j-M-Y', '15-Feb-2016');
+$date = DateTime::createFromFormat('!j-M-Y', '15-Feb-2016');
$response->setDate($date);
----------- end diff ----------- |
Yes I am in favor of updating the examples so they always match our coding standard; that was the primary reason behind splitting them out. I wish there were a way to exempt |
@paulbalandan Could you make the parallel changes over at codeigniter4/devkit as well please? |
9a387e0
to
4e2b516
Compare
Done. codeigniter4/devkit#47 |
4e2b516
to
ec0447b
Compare
Checklist: