Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: make $precision int in View Filter round #6566

Merged
merged 2 commits into from
Sep 23, 2022
Merged

refactor: make $precision int in View Filter round #6566

merged 2 commits into from
Sep 23, 2022

Conversation

kenjis
Copy link
Member

@kenjis kenjis commented Sep 22, 2022

Description
The second parameter of PHP function round() should be int.

Checklist:

  • Securely signed commits
  • Component(s) with PHPDoc blocks, only if necessary or adds value
  • Unit testing, with >80% coverage
  • User guide updated
  • Conforms to style guide

@kenjis kenjis added the refactor Pull requests that refactor code label Sep 22, 2022
MGatner
MGatner approved these changes Sep 22, 2022
View reviewed changes
Copy link
Member

@MGatner MGatner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just made a very similar fix at my day job! A lot of people also don't realize that round() returns a float.

@kenjis
refactor: make $precision int
1c59d14 
The second parameter of PHP function round() should be int.
@kenjis
test: improve test
eafb028 
It was a bit difficult to read the code.
@kenjis kenjis force-pushed the refactor-view-filter-round branch from 86fa224 to eafb028 Compare September 22, 2022 22:34
@kenjis kenjis merged commit 7959a37 into codeigniter4:develop Sep 23, 2022
@kenjis kenjis deleted the refactor-view-filter-round branch September 23, 2022 02:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MGatner MGatner MGatner approved these changes

Assignees
No one assigned
Labels
refactor Pull requests that refactor code
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kenjis @MGatner