Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: fix: update the validation mime type #6622

Merged
merged 1 commit into from
Oct 3, 2022
Merged

docs: fix: update the validation mime type #6622

merged 1 commit into from
Oct 3, 2022

Conversation

sammyskills
Copy link
Contributor

@sammyskills sammyskills commented Oct 3, 2022 •
edited
Loading

Description
The mime type for jpg, jpeg was erroneously written as image/jpg instead of image/jpeg as stated in app/Config/Mimes.php.

Checklist:

  • Securely signed commits
  • Component(s) with PHPDoc blocks, only if necessary or adds value
  • Unit testing, with >80% coverage
  • User guide updated
  • Conforms to style guide

@kenjis kenjis added the documentation Pull requests for documentation only label Oct 3, 2022
@kenjis kenjis changed the title docs:fix: update the validation mime type docs: fix: update the validation mime type Oct 3, 2022
@kenjis
Copy link
Member

kenjis commented Oct 3, 2022 •
edited
Loading

The value should be the return value of $file->getMimeType().
https://codeigniter4.github.io/CodeIgniter4/libraries/files.html#getmimetype

Yes, it is image/jpeg.

@kenjis kenjis merged commit a7fb29f into codeigniter4:develop Oct 3, 2022
@sammyskills sammyskills deleted the fix/update-validation-mime-type branch October 4, 2022 04:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@paulbalandan paulbalandan paulbalandan approved these changes

@kenjis kenjis kenjis approved these changes

Assignees
No one assigned
Labels
documentation Pull requests for documentation only
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sammyskills @kenjis @paulbalandan