Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: missing valid_json in Validation Language #6624

Merged
merged 4 commits into from
Oct 4, 2022
Merged

fix: missing valid_json in Validation Language #6624

merged 4 commits into from
Oct 4, 2022

Conversation

ddevsr
Copy link
Collaborator

@ddevsr ddevsr commented Oct 4, 2022 •
edited by kenjis
Loading

Description
Fixed #6623

Checklist:

  • Securely signed commits
  • Component(s) with PHPDoc blocks, only if necessary or adds value
  • Unit testing, with >80% coverage
  • User guide updated
  • Conforms to style guide

@ddevsr ddevsr mentioned this pull request Oct 4, 2022
Closed
@kenjis kenjis added the bug Verified issues on the current code behavior or pull requests that will fix them label Oct 4, 2022
@kenjis
Copy link
Member

kenjis commented Oct 4, 2022

Thank you!

Can you add the changelog Message Changes section?
like https://codeigniter4.github.io/CodeIgniter4/changelogs/v4.0.0-rc.1.html#message-changes

@ddevsr @datamweb
docs: message changes in changelog 4.2.7
1d5a678 
Co-authored-by: Pooya Parsa Dadashi <pooya_parsa_dadashi@yahoo.com>
@kenjis kenjis merged commit 0d002eb into codeigniter4:develop Oct 4, 2022
@kenjis
Copy link
Member

kenjis commented Oct 4, 2022

@ddevsr Thanks!

@kenjis kenjis mentioned this pull request Oct 4, 2022
Closed
@ddevsr ddevsr deleted the language-valid-json branch October 5, 2022 01:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MGatner MGatner MGatner approved these changes

@datamweb datamweb datamweb approved these changes

@kenjis kenjis kenjis approved these changes

Assignees
No one assigned
Labels
bug Verified issues on the current code behavior or pull requests that will fix them
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Bug: valid_json language string missing in /system/Language/en/Validation.php
4 participants
@ddevsr @kenjis @datamweb @MGatner