-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: renderSection
option to retained data
#7126
feat: renderSection
option to retained data
#7126
Conversation
@addngr Thank you for sending this PR! Can you add the changelog v4.4.0 based on the following? |
a03e95e
to
4416e9e
Compare
@kenjis, Thank you for quick response. Please have look changelog v4.4.0 added. |
@addngr Thank you! |
Build error occurred.
Please add |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
@addngr This branch has conflicts that must be resolved. |
d8085f9
to
29ebd67
Compare
@addngr Thank you! |
@kenjis Thank you for your valuable guidance. I have been successfully completed my 1st contribution to open source project. I have learned a lot by doing a contribution to such great work. |
@addngr Your PR was no problem. It was very well. 👍 |
Description
This PR is in reference to reported issue to resolve #7069, Added a new feature on renders a section's contents using
renderSection('page_title', true)
to prevent from auto cleans the data after displaying.Added 2nd argument
bool $saveData
If is true, saves data for subsequent calls, if false, cleans the data after displaying.Checklist: