Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: renderSection option to retained data #7126

Merged
merged 5 commits into from
Jan 20, 2023

Conversation

addngr
Copy link
Contributor

@addngr addngr commented Jan 15, 2023

Description
This PR is in reference to reported issue to resolve #7069, Added a new feature on renders a section's contents using renderSection('page_title', true) to prevent from auto cleans the data after displaying.

Added 2nd argument bool $saveData If is true, saves data for subsequent calls, if false, cleans the data after displaying.

Checklist:

  • Securely signed commits
  • Component(s) with PHPDoc blocks, only if necessary or adds value
  • Unit testing, with >80% coverage
  • User guide updated
  • Conforms to style guide

@kenjis kenjis added enhancement PRs that improve existing functionalities 4.4 labels Jan 15, 2023
@kenjis
Copy link
Member

kenjis commented Jan 16, 2023

@addngr Thank you for sending this PR!

Can you add the changelog v4.4.0 based on the following?
https://github.com/codeigniter4/CodeIgniter4/blob/develop/admin/next-changelog-minor.rst
and add about this in the Enhancements section?

@addngr addngr force-pushed the feat-renderSection-saveData-4.4 branch from a03e95e to 4416e9e Compare January 16, 2023 18:08
@addngr
Copy link
Contributor Author

addngr commented Jan 16, 2023

@kenjis, Thank you for quick response. Please have look changelog v4.4.0 added.

@kenjis
Copy link
Member

kenjis commented Jan 16, 2023

@addngr Thank you!
Generally Okay, but I commented inline on a few points.

@kenjis
Copy link
Member

kenjis commented Jan 16, 2023

Build error occurred.

/github/workspace/user_guide_src/source/changelogs/v4.4.0.rst: WARNING: document isn't included in any toctree
https://github.com/codeigniter4/CodeIgniter4/actions/runs/3932931900/jobs/6729062065

Please add v4.4.0 in the index file:
https://github.com/codeigniter4/CodeIgniter4/blob/develop/user_guide_src/source/changelogs/index.rst

Copy link
Member

@kenjis kenjis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@kenjis
Copy link
Member

kenjis commented Jan 20, 2023

@addngr This branch has conflicts that must be resolved.
Can you rebase?
See https://github.com/codeigniter4/CodeIgniter4/blob/develop/contributing/workflow.md#updating-your-branch

@addngr addngr force-pushed the feat-renderSection-saveData-4.4 branch from d8085f9 to 29ebd67 Compare January 20, 2023 04:09
@kenjis kenjis merged commit 3cbd911 into codeigniter4:4.4 Jan 20, 2023
@kenjis
Copy link
Member

kenjis commented Jan 20, 2023

@addngr Thank you!

@addngr
Copy link
Contributor Author

addngr commented Jan 20, 2023

@kenjis Thank you for your valuable guidance. I have been successfully completed my 1st contribution to open source project. I have learned a lot by doing a contribution to such great work.

@kenjis
Copy link
Member

kenjis commented Jan 20, 2023

@addngr Your PR was no problem. It was very well. 👍
In fact some people can not complete their PRs with lack of skills.
I think you could contribute most of PHP open source projects.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
4.4 enhancement PRs that improve existing functionalities
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants