Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: Update PHPDoc Common::config #7224

Merged
merged 5 commits into from
Feb 15, 2023
Merged

refactor: Update PHPDoc Common::config #7224

merged 5 commits into from
Feb 15, 2023

Conversation

maniaba
Copy link
Contributor

@maniaba maniaba commented Feb 5, 2023

Description
The @template annotation relates to a concept called Generics, which does not currently exist in PHP, but are a way of dynamically describing the contents of a parameter or return type that would be unknown until a class is instantiated or method called.

Checklist:

  • Securely signed commits
  • Component(s) with PHPDoc blocks, only if necessary or adds value
  • Unit testing, with >80% coverage
  • User guide updated
  • Conforms to style guide

@maniaba maniaba changed the title Update PHPDoc Common::config refactor: Update PHPDoc Common::config Feb 5, 2023
@kenjis kenjis added the GPG-Signing needed Pull requests that need GPG-Signing label Feb 5, 2023
@maniaba maniaba requested a review from kenjis February 5, 2023 13:08
@kenjis kenjis added refactor Pull requests that refactor code and removed GPG-Signing needed Pull requests that need GPG-Signing labels Feb 6, 2023
Copy link
Member

@kenjis kenjis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is the same thing as model(), and works with PhpStorm.

@kenjis kenjis merged commit 5726eba into codeigniter4:develop Feb 15, 2023
@kenjis
Copy link
Member

kenjis commented Feb 15, 2023

@maniaba Thank you.

We will accept the change from config('Foo') to config(Foo::class) in everywhere.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
refactor Pull requests that refactor code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants