Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: URI::setSegment() accepts the last +2 segment without Exception #7251

Merged
merged 2 commits into from
Feb 16, 2023
Merged

fix: URI::setSegment() accepts the last +2 segment without Exception #7251

merged 2 commits into from
Feb 16, 2023

Conversation

kenjis
Copy link
Member

@kenjis kenjis commented Feb 14, 2023 •
edited
Loading

Description
Fixes #7250

Related #7249

Checklist:

  • Securely signed commits
  • [] Component(s) with PHPDoc blocks, only if necessary or adds value
  • Unit testing, with >80% coverage
  • User guide updated
  • Conforms to style guide

@kenjis kenjis added bug Verified issues on the current code behavior or pull requests that will fix them breaking change Pull requests that may break existing functionalities 4.4 labels Feb 14, 2023
@kenjis kenjis mentioned this pull request Feb 14, 2023
Merged
5 tasks
michalsn
michalsn approved these changes Feb 14, 2023
View reviewed changes
Copy link
Member

@michalsn michalsn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems correct to me. We just need to add this to the changelog.

@kenjis kenjis added the docs needed Pull requests needing documentation write-ups and/or revisions. label Feb 15, 2023
@kenjis kenjis removed the docs needed Pull requests needing documentation write-ups and/or revisions. label Feb 15, 2023
@kenjis
Copy link
Member Author

kenjis commented Feb 15, 2023

Added docs.

@kenjis kenjis merged commit 0230c8b into codeigniter4:4.4 Feb 16, 2023
@kenjis kenjis deleted the fix-URI-setSegment branch February 16, 2023 23:03
@kenjis kenjis mentioned this pull request Feb 16, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@michalsn michalsn michalsn approved these changes

@MGatner MGatner MGatner approved these changes

Assignees
No one assigned
Labels
4.4 breaking change Pull requests that may break existing functionalities bug Verified issues on the current code behavior or pull requests that will fix them
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kenjis @michalsn @MGatner