-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove Config\App Session items #7255
Remove Config\App Session items #7255
Conversation
de06247
to
597e35e
Compare
Shall we add default config properties in |
It breaks. I don't see the significance of adding properties that just copies the properties of the Config class. |
3f2513f
to
9a6bcff
Compare
9a6bcff
to
3c582a1
Compare
Rebased to resolve conflicts. Can anyone review? |
3c582a1
to
482df99
Compare
Rebased. |
This PR tries to get rid of the dependency on Config\App in Services::session() to prevent an infinite loop if the Config\App constructor is accessing a session. That is, the call point of the infinite loop has shifted from Services::session() to Services::request(). |
@iRedds You are correct. But I think removing deprecated items in We have already removed the deprecated Cookie items in |
482df99
to
612f08a
Compare
Oh, I must have missed that comment. My bad. |
612f08a
to
7dda3b1
Compare
Rebased to resolve conflicts. |
I would like to merge this. Review, please. |
Description
Supersedes #7000
This PR is needed for #7308
Session should not depends on
Config\App
. See #4297 (comment)Config\App
session itemsConfig\Session
inSession
Checklist: