-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: can't change and override valid locales #7309
fix: can't change and override valid locales #7309
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
An elegant solution.
a86bf1a
to
561e249
Compare
Added docs. |
Of course this is a bit late, but what does request state have to do with locales? |
Now that we have added I found that we still cannot change valid locales for content negotiation: CodeIgniter4/system/HTTP/IncomingRequest.php Line 220 in e1c13f6
in the constructor: CodeIgniter4/system/HTTP/IncomingRequest.php Line 179 in e1c13f6
|
Description
Fixes #4297
IncomingRequest::setValidLocales()
Checklist: