Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Validation::check() does not accept array rules #7424

Merged
merged 4 commits into from
Apr 13, 2023
Merged

fix: Validation::check() does not accept array rules #7424

merged 4 commits into from
Apr 13, 2023

Conversation

kenjis
Copy link
Member

@kenjis kenjis commented Apr 12, 2023 •
edited
Loading

Description
Validation::check() should accept array rules.
In #5545, string for $rules in setRule() was removed.

Checklist:

  • Securely signed commits
  • Component(s) with PHPDoc blocks, only if necessary or adds value
  • Unit testing, with >80% coverage
  • User guide updated
  • Conforms to style guide

@kenjis kenjis added bug Verified issues on the current code behavior or pull requests that will fix them 4.4 labels Apr 12, 2023
@kenjis kenjis force-pushed the fix-validation-check-rule-type branch from 1c80e74 to f625e5e Compare April 12, 2023 23:35
@kenjis kenjis force-pushed the fix-validation-check-rule-type branch from f625e5e to 2962b16 Compare April 13, 2023 02:40
@kenjis kenjis merged commit 82a30b8 into codeigniter4:4.4 Apr 13, 2023
@kenjis kenjis deleted the fix-validation-check-rule-type branch April 13, 2023 07:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@michalsn michalsn michalsn approved these changes

Assignees
No one assigned
Labels
4.4 bug Verified issues on the current code behavior or pull requests that will fix them
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kenjis @michalsn