-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove Config\App Security items #7630
Remove Config\App Security items #7630
Conversation
9468915
to
1c7d51c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Small, but massive change.
Not sure how many people extend the Security
class (probably something around 0) but having config variables in $this->config
will definitely break some things for those cases.
Anyway, I'm a bit baffled about this change with setting config items to the $this->config
and depreciations.
$CSRFExpire was removed.
889445f
to
2868f5c
Compare
27503a6
to
9df83ad
Compare
9df83ad
to
24e9cad
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. Thanks!
Description
Config\App
Security
constructor param fromConfig\App
toConfig\Security
Checklist: