Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: domparser - ability to write more advanced expressions #7946

Merged
merged 7 commits into from
Sep 20, 2023

Conversation

michalsn
Copy link
Member

Description
The DomParser class is great for simple expressions, but if we want to check something more complicated, it unfortunately doesn't give us that option.

Therefore, this PR adds the ability to write an expression that will be executed directly by the DOMXPath class.
This way we can handle more advanced scenarios, like searching for nested elements in the DOM.

Checklist:

  • Securely signed commits
  • Component(s) with PHPDoc blocks, only if necessary or adds value
  • Unit testing, with >80% coverage
  • User guide updated
  • Conforms to style guide

@michalsn
Copy link
Member Author

Not sure why, but unrelated to this PR checks fail.

@kenjis kenjis added enhancement PRs that improve existing functionalities wrong branch PRs sent to wrong branch labels Sep 16, 2023
@kenjis
Copy link
Member

kenjis commented Sep 16, 2023

@michalsn This is an enhancement. Please change the base branch to 4.5.

@michalsn michalsn changed the base branch from develop to 4.5 September 17, 2023 06:03
@michalsn michalsn removed the wrong branch PRs sent to wrong branch label Sep 17, 2023
@michalsn
Copy link
Member Author

@kenjis Done.

michalsn and others added 2 commits September 17, 2023 18:52
@kenjis kenjis added the 4.5 label Sep 18, 2023
@kenjis kenjis merged commit 0280297 into codeigniter4:4.5 Sep 20, 2023
61 of 62 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
4.5 enhancement PRs that improve existing functionalities
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants