-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: spark may not show exceptions or show backtrace as json #7962
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kenjis
added
the
bug
Verified issues on the current code behavior or pull requests that will fix them
label
Sep 23, 2023
kenjis
changed the title
fix: bug that spark does not show Exception
fix: spark does not show Exception
Sep 23, 2023
kenjis
force-pushed
the
fix-spark-no-error-msg
branch
from
September 25, 2023 00:30
1aaeda2
to
b19769c
Compare
Added the docs. |
kenjis
changed the title
fix: spark does not show Exception
fix: spark may not show Exception
Sep 25, 2023
kenjis
force-pushed
the
fix-spark-no-error-msg
branch
2 times, most recently
from
September 25, 2023 01:34
e3e0c07
to
539a56b
Compare
kenjis
changed the title
fix: spark may not show Exception
fix: spark shows backtrace as json
Sep 25, 2023
kenjis
changed the title
fix: spark shows backtrace as json
fix: spark may show backtrace as json
Sep 25, 2023
kenjis
force-pushed
the
fix-spark-no-error-msg
branch
from
September 25, 2023 01:55
539a56b
to
aeed049
Compare
kenjis
force-pushed
the
fix-spark-no-error-msg
branch
from
September 25, 2023 02:21
aeed049
to
c2829d9
Compare
kenjis
changed the title
fix: spark may show backtrace as json
fix: spark may not show exceptions or show backtrace as json
Sep 25, 2023
kenjis
force-pushed
the
fix-spark-no-error-msg
branch
2 times, most recently
from
September 25, 2023 02:39
9b86813
to
0bd18e8
Compare
datamweb
reviewed
Sep 25, 2023
👋 Hi, @kenjis! |
kenjis
force-pushed
the
fix-spark-no-error-msg
branch
from
October 8, 2023 23:07
0bd18e8
to
b201faf
Compare
Rebased to resolve a conflict. |
MGatner
approved these changes
Oct 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fix a bug that
spark
may not show exceptions in production mode, or show backtrace as json.How to Reproduce
(1) Setup MySQL and use the default Config (no
.env
). That isdatabase
is an empty string and inproduction
mode.Before:
After:
(2) Change to
development
mode.Before:
After:
Checklist: