Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: named routes don't work with spark #8028

Merged
merged 1 commit into from
Oct 13, 2023
Merged

fix: named routes don't work with spark #8028

merged 1 commit into from
Oct 13, 2023

Conversation

kenjis
Copy link
Member

@kenjis kenjis commented Oct 11, 2023

Description
Fixes #8027

Checklist:

  • Securely signed commits
  • Component(s) with PHPDoc blocks, only if necessary or adds value
  • Unit testing, with >80% coverage
  • User guide updated
  • Conforms to style guide

@kenjis kenjis added the bug Verified issues on the current code behavior or pull requests that will fix them label Oct 11, 2023
@kenjis kenjis mentioned this pull request Oct 11, 2023
Closed
michalsn
michalsn approved these changes Oct 11, 2023
View reviewed changes
Copy link
Member

@michalsn michalsn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's working. Thank you.

Can we expect the release of 4.4.2 in the near future? That would be great.

@kenjis
Copy link
Member Author

kenjis commented Oct 11, 2023

Once these bugs are fixed,, I would like to release v4.4.2.
https://github.com/codeigniter4/CodeIgniter4/pulls?q=is%3Apr+is%3Aopen+label%3Abug+-label%3A4.5+author%3Akenjis

@kenjis kenjis merged commit 586b9f2 into codeigniter4:develop Oct 13, 2023
61 checks passed
@kenjis kenjis deleted the fix-spark-named-routes branch October 13, 2023 00:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MGatner MGatner MGatner approved these changes

@michalsn michalsn michalsn approved these changes

Assignees
No one assigned
Labels
bug Verified issues on the current code behavior or pull requests that will fix them
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Bug: named routes doesn't work in CLI
3 participants
@kenjis @michalsn @MGatner