Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: add a primary key to an existing table #8031

Merged
merged 3 commits into from
Oct 13, 2023
Merged

fix: add a primary key to an existing table #8031

merged 3 commits into from
Oct 13, 2023

Conversation

michalsn
Copy link
Member

Description
Fixes: #8019

Checklist:

  • Securely signed commits
  • Component(s) with PHPDoc blocks, only if necessary or adds value
  • Unit testing, with >80% coverage
  • User guide updated
  • Conforms to style guide

@kenjis kenjis added the bug Verified issues on the current code behavior or pull requests that will fix them label Oct 11, 2023
@kenjis
Copy link
Member

kenjis commented Oct 11, 2023

On develop it is surely fails the testProcessIndexesWithPrimaryKeyOnly.

$ vendor/bin/phpunit tests/system/Database/Live/ForgeTest.php
PHPUnit 9.6.13 by Sebastian Bergmann and contributors.

Runtime:       PHP 8.1.24
Configuration: /.../CodeIgniter4/phpunit.xml

............................................F.                                                                            46 / 46 (100%)

...


Time: 00:44.055, Memory: 18.00 MB

There was 1 failure:

1) CodeIgniter\Database\Live\ForgeTest::testProcessIndexesWithPrimaryKeyOnly
Failed asserting that actual size 0 matches expected size 1.

/.../CodeIgniter4/tests/system/Database/Live/ForgeTest.php:1705

FAILURES!
Tests: 46, Assertions: 112, Failures: 1.

kenjis
kenjis approved these changes Oct 11, 2023
View reviewed changes
Copy link
Member

@kenjis kenjis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thank you.

@kenjis kenjis mentioned this pull request Oct 11, 2023
Closed
MGatner
MGatner approved these changes Oct 12, 2023
View reviewed changes
Copy link
Member

@MGatner MGatner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You get my rare database-related approval 😉

@kenjis kenjis merged commit ce62326 into codeigniter4:develop Oct 13, 2023
62 checks passed
@michalsn michalsn deleted the fix/processIndexes branch November 13, 2023 07:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kenjis kenjis kenjis approved these changes

@MGatner MGatner MGatner approved these changes

Assignees
No one assigned
Labels
bug Verified issues on the current code behavior or pull requests that will fix them
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Bug: Adding a primary key to an existing table not working
3 participants
@michalsn @kenjis @MGatner