Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: fix helper loading #8084

Merged
merged 5 commits into from
Oct 25, 2023
Merged

docs: fix helper loading #8084

merged 5 commits into from
Oct 25, 2023

Conversation

kenjis
Copy link
Member

@kenjis kenjis commented Oct 23, 2023 •
edited
Loading

Description
The helper loading description is still CI3's and differs from the current behavior.

Checklist:

  • Securely signed commits
  • [] Component(s) with PHPDoc blocks, only if necessary or adds value
  • [] Unit testing, with >80% coverage
  • User guide updated
  • [] Conforms to style guide

@kenjis kenjis added bug Verified issues on the current code behavior or pull requests that will fix them documentation Pull requests for documentation only labels Oct 23, 2023
@kenjis kenjis merged commit b92057c into codeigniter4:develop Oct 25, 2023
62 checks passed
@kenjis kenjis deleted the docs-fix-helper-loading branch October 25, 2023 20:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MGatner MGatner MGatner approved these changes

@michalsn michalsn michalsn approved these changes

Assignees
No one assigned
Labels
bug Verified issues on the current code behavior or pull requests that will fix them documentation Pull requests for documentation only
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kenjis @michalsn @MGatner