Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: remove deprecated spark commands #8086

Merged
merged 3 commits into from
Oct 24, 2023
Merged

refactor: remove deprecated spark commands #8086

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
44a8d31
refactor: remove deprecated spark commands
kenjis Oct 24, 2023
30dfb8b
docs: add changelog
kenjis Oct 24, 2023
5298f2a
test: update test code
kenjis Oct 24, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
35 changes: 0 additions & 35 deletions phpstan-baseline.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -651,41 +651,6 @@
'count' => 2,
'path' => __DIR__ . '/system/Commands/Generators/SeederGenerator.php',
];
$ignoreErrors[] = [
'message' => '#^Construct empty\\(\\) is not allowed\\. Use more strict comparison\\.$#',
'count' => 2,
'path' => __DIR__ . '/system/Commands/Generators/SessionMigrationGenerator.php',
];
$ignoreErrors[] = [
'message' => '#^Method CodeIgniter\\\\Commands\\\\Generators\\\\SessionMigrationGenerator\\:\\:generateClass\\(\\) has no return type specified\\.$#',
'count' => 1,
'path' => __DIR__ . '/system/Commands/Generators/SessionMigrationGenerator.php',
];
$ignoreErrors[] = [
'message' => '#^Method CodeIgniter\\\\Commands\\\\Generators\\\\SessionMigrationGenerator\\:\\:generateView\\(\\) has no return type specified\\.$#',
'count' => 1,
'path' => __DIR__ . '/system/Commands/Generators/SessionMigrationGenerator.php',
];
$ignoreErrors[] = [
'message' => '#^Only booleans are allowed in &&, mixed given on the left side\\.$#',
'count' => 1,
'path' => __DIR__ . '/system/Commands/Generators/SessionMigrationGenerator.php',
];
$ignoreErrors[] = [
'message' => '#^Only booleans are allowed in &&, mixed given on the right side\\.$#',
'count' => 1,
'path' => __DIR__ . '/system/Commands/Generators/SessionMigrationGenerator.php',
];
$ignoreErrors[] = [
'message' => '#^Only booleans are allowed in a negated boolean, mixed given\\.$#',
'count' => 1,
'path' => __DIR__ . '/system/Commands/Generators/SessionMigrationGenerator.php',
];
$ignoreErrors[] = [
'message' => '#^Short ternary operator is not allowed\\. Use null coalesce operator if applicable or consider using long ternary\\.$#',
'count' => 2,
'path' => __DIR__ . '/system/Commands/Generators/SessionMigrationGenerator.php',
];
$ignoreErrors[] = [
'message' => '#^Construct empty\\(\\) is not allowed\\. Use more strict comparison\\.$#',
'count' => 2,
Expand Down
90 changes: 0 additions & 90 deletions system/Commands/Generators/MigrateCreate.php
View file
Open in desktop

This file was deleted.

113 changes: 0 additions & 113 deletions system/Commands/Generators/SessionMigrationGenerator.php
View file
Open in desktop

This file was deleted.

2 changes: 1 addition & 1 deletion tests/system/CLI/ConsoleTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -90,7 +90,7 @@ public function testBadCommand(): void

public function testHelpCommandDetails(): void
{
$this->initCLI('help', 'session:migration');
$this->initCLI('help', 'make:migration');

$console = new Console();
$console->run();
Expand Down
6 changes: 6 additions & 0 deletions user_guide_src/source/changelogs/v4.5.0.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -127,6 +127,12 @@ Test
- ``FeatureResponse``
- ``FeatureTestCase``

Spark Commands
--------------

- ``migrate:create``
- ``session:migration``

Others
------

Expand Down
4 changes: 0 additions & 4 deletions user_guide_src/source/cli/cli_generators.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,10 +36,6 @@ where ``<generator_command>`` will be replaced with the command to check.
namespace defined in your ``$psr4`` array in ``Config\Autoload`` or defined in your composer autoload
file. Otherwise, code generation will be interrupted.

.. important:: Since v4.0.5, use of ``migrate:create`` to create migration files has been deprecated. It will be removed in
future releases. Please use ``make:migration`` as replacement. Also, please use ``make:migration --session``
to use instead of the deprecated ``session:migration``.

*******************
Built-in Generators
*******************
Expand Down
Loading