Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Rector] Apply SingleInArrayToCompareRector #8102

Merged
merged 1 commit into from
Oct 27, 2023
Merged

[Rector] Apply SingleInArrayToCompareRector #8102

merged 1 commit into from
Oct 27, 2023

Conversation

samsonasik
Copy link
Member

Description

Changes in_array() with single element to identical check.

Checklist:

  • Securely signed commits
  • Component(s) with PHPDoc blocks, only if necessary or adds value
  • Unit testing, with >80% coverage
  • User guide updated
  • Conforms to style guide

@samsonasik
Copy link
Member Author

Ready to merge 👍

@kenjis kenjis added the refactor Pull requests that refactor code label Oct 27, 2023
@samsonasik samsonasik merged commit c6d9179 into codeigniter4:develop Oct 27, 2023
59 checks passed
@samsonasik
Copy link
Member Author

Thank you @paulbalandan @kenjis for the review 👍

@samsonasik samsonasik deleted the single-in-array branch October 27, 2023 06:44
MGatner
MGatner reviewed Oct 27, 2023
View reviewed changes
Copy link
Member

@MGatner MGatner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Kinda makes you wonder how some of these got here to begin with 😅 Thanks for this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MGatner MGatner MGatner left review comments

@kenjis kenjis kenjis approved these changes

@paulbalandan paulbalandan paulbalandan approved these changes

Assignees
No one assigned
Labels
refactor Pull requests that refactor code
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@samsonasik @kenjis @MGatner @paulbalandan