Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[4.5] refactor: fix types #8138

Merged
merged 9 commits into from
Nov 7, 2023
Merged

[4.5] refactor: fix types #8138

merged 9 commits into from
Nov 7, 2023

Conversation

kenjis
Copy link
Member

@kenjis kenjis commented Nov 3, 2023 •
edited
Loading

Description

Checklist:

  • Securely signed commits
  • Component(s) with PHPDoc blocks, only if necessary or adds value
  • Unit testing, with >80% coverage
  • User guide updated
  • Conforms to style guide

@kenjis kenjis added refactor Pull requests that refactor code 4.5 labels Nov 3, 2023
@kenjis kenjis mentioned this pull request Nov 3, 2023
Merged
5 tasks
@kenjis kenjis changed the title refactor: fix types [4.5] refactor: fix types Nov 3, 2023
MGatner
MGatner requested changes Nov 5, 2023
View reviewed changes
system/Database/MigrationRunner.php Outdated Show resolved Hide resolved
system/Test/CIUnitTestCase.php Outdated Show resolved Hide resolved
@kenjis kenjis requested a review from MGatner November 7, 2023 02:52
@kenjis kenjis merged commit f432f41 into codeigniter4:4.5 Nov 7, 2023
45 checks passed
@kenjis kenjis deleted the fix-types branch November 7, 2023 21:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MGatner MGatner MGatner approved these changes

Assignees
No one assigned
Labels
4.5 refactor Pull requests that refactor code
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kenjis @MGatner