Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: @return in filter.tpl.php #8145

Merged
merged 1 commit into from
Nov 7, 2023
Merged

fix: @return in filter.tpl.php #8145

merged 1 commit into from
Nov 7, 2023

Conversation

kenjis
Copy link
Member

@kenjis kenjis commented Nov 4, 2023

Description
See #6310

  • fix @return in filter.tpl.php

Checklist:

  • Securely signed commits
  • [] Component(s) with PHPDoc blocks, only if necessary or adds value
  • [] Unit testing, with >80% coverage
  • [] User guide updated
  • Conforms to style guide

@kenjis kenjis added the bug Verified issues on the current code behavior or pull requests that will fix them label Nov 4, 2023
michalsn
michalsn reviewed Nov 6, 2023
View reviewed changes
Copy link
Member

@michalsn michalsn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why null is not an option?

@kenjis
Copy link
Member Author

kenjis commented Nov 7, 2023

Because there is not null in the interface.

CodeIgniter4/system/Filters/FilterInterface.php

Line 34 in 6c187dd

* @return RequestInterface|ResponseInterface|string|void

The fewer types the better. is there any reason why we need null?

@MGatner
Copy link
Member

MGatner commented Nov 7, 2023

null/void is kind of a bogus return type distinction in PHP. I think matching the interface is the way to go.

@michalsn
Copy link
Member

michalsn commented Nov 7, 2023

The fewer types the better. is there any reason why we need null?

Nah, I haven't checked the interface. Sounds good. I probably saw null somewhere else.

@kenjis kenjis merged commit 46ab4c6 into codeigniter4:develop Nov 7, 2023
61 checks passed
@kenjis kenjis deleted the fix-types-in-filter.tpl.php branch November 7, 2023 21:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@michalsn michalsn michalsn approved these changes

@MGatner MGatner MGatner approved these changes

Assignees
No one assigned
Labels
bug Verified issues on the current code behavior or pull requests that will fix them
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kenjis @MGatner @michalsn