Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: RedisHandler ttl() calls #8155

Merged
merged 1 commit into from
Nov 6, 2023
Merged

refactor: RedisHandler ttl() calls #8155

merged 1 commit into from
Nov 6, 2023

Conversation

kenjis
Copy link
Member

@kenjis kenjis commented Nov 6, 2023 •
edited
Loading

Description

Error: Comparison operation ">" between (int|Redis|false) and 0 results in an error.
Error: Ignored error pattern #^Only booleans are allowed in a negated boolean, int given\.$# in path /home/runner/work/CodeIgniter4/CodeIgniter4/system/Session/Handlers/RedisHandler.php was not matched in reported errors.
Error: Comparison operation ">" between (int|Redis|false) and 0 results in an error.
 ------ --------------------------------------------------------------------- 
  Line   system/Cache/Handlers/RedisHandler.php                               
 ------ --------------------------------------------------------------------- 
  250    Comparison operation ">" between (int|Redis|false) and 0 results in  
         an error.                                                            
 ------ --------------------------------------------------------------------- 

 ------ -------------------------------------------------------------------------------------- 
  Line   system/Session/Handlers/RedisHandler.php                                              
 ------ -------------------------------------------------------------------------------------- 
         Ignored error pattern #^Only booleans are allowed in a negated                        
         boolean, int given\.$# in path                                                        
         /home/runner/work/CodeIgniter4/CodeIgniter4/system/Session/Handlers/RedisHandler.php  
         was not matched in reported errors.                                                   
  296    Comparison operation ">" between (int|Redis|false) and 0 results in                   
         an error.                                                                             
 ------ --------------------------------------------------------------------------------------

https://github.com/codeigniter4/CodeIgniter4/actions/runs/6763592529/job/18380895677

Checklist:

  • Securely signed commits
  • Component(s) with PHPDoc blocks, only if necessary or adds value
  • Unit testing, with >80% coverage
  • User guide updated
  • Conforms to style guide

@kenjis kenjis added the refactor Pull requests that refactor code label Nov 6, 2023
@kenjis
Copy link
Member Author

kenjis commented Nov 6, 2023

PHPStan now reports errors. Please review.

@kenjis kenjis merged commit 1c33359 into codeigniter4:develop Nov 6, 2023
61 checks passed
@kenjis kenjis deleted the refactor-redis-ttl branch November 6, 2023 01:06
@kenjis
Copy link
Member Author

kenjis commented Nov 6, 2023

Thank you! @paulbalandan

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@paulbalandan paulbalandan paulbalandan approved these changes

Assignees
No one assigned
Labels
refactor Pull requests that refactor code
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kenjis @paulbalandan