Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: when request body is 0, $body will be null #8161

Merged
merged 5 commits into from
Nov 7, 2023
Merged

fix: when request body is 0, $body will be null #8161

merged 5 commits into from
Nov 7, 2023

Conversation

kenjis
Copy link
Member

@kenjis kenjis commented Nov 7, 2023 •
edited
Loading

Description

  • fix bug that when request body is 0, $body will be null

Checklist:

  • Securely signed commits
  • Component(s) with PHPDoc blocks, only if necessary or adds value
  • Unit testing, with >80% coverage
  • User guide updated
  • Conforms to style guide

@kenjis kenjis added the bug Verified issues on the current code behavior or pull requests that will fix them label Nov 7, 2023
@kenjis kenjis mentioned this pull request Nov 7, 2023
Merged
5 tasks
MGatner
MGatner approved these changes Nov 7, 2023
View reviewed changes
Copy link
Member

@MGatner MGatner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

empty() may have been the biggest mistake in all of PHP history.

@kenjis kenjis merged commit 0708fd7 into codeigniter4:develop Nov 7, 2023
61 checks passed
@kenjis kenjis deleted the fix-Request-body-0 branch November 7, 2023 21:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@michalsn michalsn michalsn approved these changes

@MGatner MGatner MGatner approved these changes

Assignees
No one assigned
Labels
bug Verified issues on the current code behavior or pull requests that will fix them
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kenjis @michalsn @MGatner