Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: spark routes outputs <unknown> only when {locale} with useSupportedLocalesOnly(true) #8167

Merged
merged 1 commit into from
Nov 8, 2023
Merged

fix: spark routes outputs <unknown> only when {locale} with useSupportedLocalesOnly(true) #8167

merged 1 commit into from
Nov 8, 2023

Conversation

kenjis
Copy link
Member

@kenjis kenjis commented Nov 7, 2023

Description
Fixes #7997
See #7997 (comment)

Checklist:

  • Securely signed commits
  • Component(s) with PHPDoc blocks, only if necessary or adds value
  • Unit testing, with >80% coverage
  • User guide updated
  • Conforms to style guide

@kenjis kenjis added the bug Verified issues on the current code behavior or pull requests that will fix them label Nov 7, 2023
This was referenced Nov 7, 2023
Closed
Closed
neznaika0
neznaika0 approved these changes Nov 8, 2023
View reviewed changes
Copy link
Contributor

@neznaika0 neznaika0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything seems to be working. However, this is not how we planned. Oh, well

@kenjis kenjis merged commit 4057489 into codeigniter4:develop Nov 8, 2023
61 checks passed
@kenjis kenjis deleted the fix-spark-routes-useSupportedLocalesOnly branch November 8, 2023 21:54
@kenjis kenjis changed the title fix: spark routes outputs <unknown> only when {locale} with useSupportedLocalesOnly(true) fix: spark routes outputs <unknown> only when {locale} with useSupportedLocalesOnly(true) Nov 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@michalsn michalsn michalsn approved these changes

@neznaika0 neznaika0 neznaika0 approved these changes

Assignees
No one assigned
Labels
bug Verified issues on the current code behavior or pull requests that will fix them
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Bug: [Command] spark routes for routes containing {locale} return unknown filters
3 participants
@kenjis @michalsn @neznaika0