Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: spark routes shows "Required Filters" #8237

Merged
merged 1 commit into from
Dec 16, 2023

Conversation

kenjis
Copy link
Member

@kenjis kenjis commented Nov 20, 2023

Needs #8235, #8236

Description
Follow-up #8053

$ ./spark routes

CodeIgniter v4.4.3 Command Line Tool - Server Time: 2023-11-20 07:17:40 UTC+00:00

+--------+-------+------+------------------------------+----------------+---------------+
| Method | Route | Name | Handler                      | Before Filters | After Filters |
+--------+-------+------+------------------------------+----------------+---------------+
| GET    | /     | »    | \App\Controllers\Home::index |                |               |
+--------+-------+------+------------------------------+----------------+---------------+

Required Before Filters: forcehttps, pagecache
 Required After Filters: pagecache, performance, toolbar

Checklist:

  • Securely signed commits
  • Component(s) with PHPDoc blocks, only if necessary or adds value
  • Unit testing, with >80% coverage
  • User guide updated
  • Conforms to style guide

@kenjis kenjis added enhancement PRs that improve existing functionalities 4.5 labels Nov 20, 2023
@kenjis kenjis marked this pull request as draft November 20, 2023 07:18
@kenjis kenjis force-pushed the feat-spark-routes-required-filters branch 2 times, most recently from baa9777 to 7e8d965 Compare November 20, 2023 07:38
@github-actions github-actions bot added the stale Pull requests with conflicts label Nov 27, 2023
Copy link

👋 Hi, @kenjis!

We detected conflicts in your PR against the base branch 🙊
You may want to sync 🔄 your branch with upstream!

Ref: Syncing Your Branch

@kenjis kenjis force-pushed the feat-spark-routes-required-filters branch 2 times, most recently from 6806ec5 to 3f271d0 Compare November 29, 2023 04:24
@kenjis kenjis removed the stale Pull requests with conflicts label Nov 29, 2023
@kenjis kenjis force-pushed the feat-spark-routes-required-filters branch from 3f271d0 to 31823a6 Compare December 2, 2023 22:01
@kenjis kenjis marked this pull request as ready for review December 2, 2023 22:02
@michalsn
Copy link
Member

Not sure what "required" filters refer to - are these global filters? If yes, will this info be accurate if someone uses exclude option for one of them?

If I understand correctly, the goal here is to make custom filters more readable. Maybe we can just change the color for global filters?

@kenjis
Copy link
Member Author

kenjis commented Dec 15, 2023

Sorry, the "Follow-up" PR No. in the Description was wrong.
It is #8053

"Required Filters" are special filters that are applied before and after other kinds of filters, and
always applied even if a route does not exist. There is no way to exclude.

Now in 4.5, spark routes does not show "Required Filters" at all.

@michalsn
Copy link
Member

Ok, that makes sense. Thanks.

@kenjis kenjis merged commit a55a9c0 into codeigniter4:4.5 Dec 16, 2023
45 checks passed
@kenjis kenjis deleted the feat-spark-routes-required-filters branch December 16, 2023 20:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
4.5 enhancement PRs that improve existing functionalities
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants