Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: remove unused exception classes #8468

Merged
merged 2 commits into from
Jan 30, 2024
Merged

refactor: remove unused exception classes #8468

merged 2 commits into from
Jan 30, 2024

Conversation

kenjis
Copy link
Member

@kenjis kenjis commented Jan 27, 2024 •
edited
Loading

Description

  • remove unused exception classes

Checklist:

  • Securely signed commits
  • Component(s) with PHPDoc blocks, only if necessary or adds value
  • Unit testing, with >80% coverage
  • User guide updated
  • Conforms to style guide

@kenjis kenjis added refactor Pull requests that refactor code 4.5 labels Jan 27, 2024
paulbalandan
paulbalandan approved these changes Jan 27, 2024
View reviewed changes
Copy link
Member

@paulbalandan paulbalandan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this be on the changelog?

michalsn
michalsn approved these changes Jan 27, 2024
View reviewed changes
Copy link
Member

@michalsn michalsn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think anyone uses it, but yes - we should mention it in the changelog.

@kenjis
Copy link
Member Author

kenjis commented Jan 28, 2024

Added changelog.

@kenjis kenjis merged commit 50cc0df into codeigniter4:4.5 Jan 30, 2024
48 checks passed
@kenjis kenjis deleted the remove-unused-exceptions branch January 30, 2024 23:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@michalsn michalsn michalsn approved these changes

@paulbalandan paulbalandan paulbalandan approved these changes

Assignees
No one assigned
Labels
4.5 refactor Pull requests that refactor code
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kenjis @michalsn @paulbalandan