Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: [ImageMagickHandler] early terminate processing of invalid library path #8680

Merged
merged 1 commit into from
Mar 30, 2024
Merged

fix: [ImageMagickHandler] early terminate processing of invalid library path #8680

merged 1 commit into from
Mar 30, 2024

Conversation

paulbalandan
Copy link
Member

Description
We should check if the convert program exists before doing any processing. Currently, it just checks for a non-empty string in the config file, which is insufficient.

Checklist:

  • Securely signed commits
  • Component(s) with PHPDoc blocks, only if necessary or adds value
  • Unit testing, with >80% coverage
  • User guide updated
  • Conforms to style guide

@paulbalandan paulbalandan added the bug Verified issues on the current code behavior or pull requests that will fix them label Mar 29, 2024
@kenjis kenjis changed the title fix: early terminate processing of invalid library path fix: [ImageMagickHandler] early terminate processing of invalid library path Mar 30, 2024
kenjis
kenjis approved these changes Mar 30, 2024
View reviewed changes
Copy link
Member

@kenjis kenjis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@kenjis
Copy link
Member

kenjis commented Mar 30, 2024

However, there is a lot of room for improvement in this class.

@paulbalandan
Copy link
Member Author

Actually, I'm already looking at those issues since yesterday and might open a PR soon. 🤞

@paulbalandan
Copy link
Member Author

Moved checking of convert to constructor.

@paulbalandan paulbalandan merged commit f22b8cf into codeigniter4:develop Mar 30, 2024
56 checks passed
@paulbalandan paulbalandan deleted the imagemagick-library-path branch March 30, 2024 08:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@samsonasik samsonasik samsonasik left review comments

@kenjis kenjis kenjis approved these changes

Assignees
No one assigned
Labels
bug Verified issues on the current code behavior or pull requests that will fix them
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@paulbalandan @kenjis @samsonasik