Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Pager::only([]) does not work #8702

Merged
merged 2 commits into from
Apr 5, 2024
Merged

fix: Pager::only([]) does not work #8702

merged 2 commits into from
Apr 5, 2024

Conversation

kenjis
Copy link
Member

@kenjis kenjis commented Apr 3, 2024 •
edited
Loading

Description
Closes #8698
See #8698 (comment)

Checklist:

  • Securely signed commits
  • Component(s) with PHPDoc blocks, only if necessary or adds value
  • Unit testing, with >80% coverage
  • User guide updated
  • Conforms to style guide

@kenjis kenjis added the bug Verified issues on the current code behavior or pull requests that will fix them label Apr 3, 2024
@kenjis kenjis mentioned this pull request Apr 3, 2024
Closed
crustamet
crustamet approved these changes Apr 3, 2024
View reviewed changes
Copy link
Contributor

@crustamet crustamet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this works for me

datamweb
datamweb approved these changes Apr 3, 2024
View reviewed changes
Copy link
Contributor

@datamweb datamweb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks.

@kenjis kenjis merged commit 289cd96 into codeigniter4:develop Apr 5, 2024
56 checks passed
@kenjis kenjis deleted the fix-pager-only-empty branch April 5, 2024 07:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@crustamet crustamet crustamet approved these changes

@datamweb datamweb datamweb approved these changes

@michalsn michalsn michalsn approved these changes

Assignees
No one assigned
Labels
bug Verified issues on the current code behavior or pull requests that will fix them
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Pager does not remove queryString from uri when pager is set to work on segments
4 participants
@kenjis @michalsn @datamweb @crustamet